Skip to content

Conversation

@akameco
Copy link
Owner

@akameco akameco commented Aug 8, 2019

What: https://github.com/akameco/extract-react-intl をマージします

Why: 密結合しており管理が複雑なので、一つのレポジトリに統合し、開発をしやすくする狙いがあります。

How:

git subtreeを使いextract-react-intlを持ってきました。

git remote add extract-intl https://github.com/akameco/extract-react-intl
git subtree add --prefix=extract-react-intl extract-intl master

この後、不要なファイルの削除やテストの調整を実行しました

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table N/A

akameco and others added 30 commits April 22, 2017 19:55
The current implementation of `getBabelrc` doesn't consider [`env` option of .babelrc](https://babeljs.io/docs/usage/babelrc/), which causes an error when a project has extract-react-intl-specific settings under `env` option.
This commit fixes the above problem by properly handling `env` option using the values of BABEL_ENV, NODE_ENV.

It could be debatable whether this is dealt with by read-babelrc-up or this package, but I believe the former should return the exact content of .babelrc without any modifications or merges, so I've forked this package.
The `removePrefix` option seems to be period-separated rather than slash-separated if you look at how `removePrefix` is implemented in [react-intl-auto](https://github.com/akameco/babel-plugin-react-intl-auto/blob/master/src/index.js#L47).
Consider env values when parsing .babrlrc
akameco and others added 28 commits May 28, 2018 23:17
The user can now choose to use babel 6 or babel 7.
chore: make babel-core a peer dependency
Allow to specify custom module name passed to babel-plugin-react-intl
…64e058f849'

git-subtree-dir: extract-react-intl
git-subtree-mainline: 698f1ed
git-subtree-split: 64f6800
@akameco akameco merged commit 8ba782c into master Aug 8, 2019
@akameco akameco deleted the merge-extract-react-intl branch August 8, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants