-
Notifications
You must be signed in to change notification settings - Fork 42
Merge extract-react-intl #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `getBabelrc` doesn't consider [`env` option of .babelrc](https://babeljs.io/docs/usage/babelrc/), which causes an error when a project has extract-react-intl-specific settings under `env` option. This commit fixes the above problem by properly handling `env` option using the values of BABEL_ENV, NODE_ENV. It could be debatable whether this is dealt with by read-babelrc-up or this package, but I believe the former should return the exact content of .babelrc without any modifications or merges, so I've forked this package.
The `removePrefix` option seems to be period-separated rather than slash-separated if you look at how `removePrefix` is implemented in [react-intl-auto](https://github.com/akameco/babel-plugin-react-intl-auto/blob/master/src/index.js#L47).
Consider env values when parsing .babrlrc
chore(npm): update
The user can now choose to use babel 6 or babel 7.
chore: make babel-core a peer dependency
feat: Drop node v6
refactor(deps): update babel7
Allow to specify custom module name passed to babel-plugin-react-intl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: https://github.com/akameco/extract-react-intl をマージします
Why: 密結合しており管理が複雑なので、一つのレポジトリに統合し、開発をしやすくする狙いがあります。
How:
git subtreeを使いextract-react-intlを持ってきました。
この後、不要なファイルの削除やテストの調整を実行しました
Checklist: